re-implement cache folder detection #11130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
changed the title
ndeloof
force-pushed
the
cachefile
branch
2 times, most recently
from
4c290e7
to
d6be77e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11130 +/- ##
==========================================
- Coverage 57.42% 57.11% -0.31%
==========================================
Files 129 133 +4
Lines 11299 11324 +25
==========================================
- Hits 6488 6468 -20
- Misses 4182 4230 +48
+ Partials 629 626 -3
☔ View full report in Codecov by Sentry. |
ndeloof
force-pushed
the
cachefile
branch
3 times, most recently
from
2f66695
to
943a049
Compare
If this implementation is copying the original code, we probably must include the copyright information from the original; |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza and
laurazard
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
replace
xdg.CacheFilewith our own implementation (basically, a copy/paste) so that we detectHOMEis not set and don't assume we can use/as a replacement. Unclear to me if this is legitimate from a Posix point of view, but we should offer users a better error message for diagnostic than "can't write /.cache/docker-compose"Related issue
closes #11126
closes #11137
(not mandatory) A picture of a cute animal, if possible in relation to what you did