Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --hash regression #11146

Merged
merged 1 commit into from Oct 27, 2023
Merged

Fix --hash regression #11146

merged 1 commit into from Oct 27, 2023

Conversation

mattwalo32
Copy link
Contributor

What I did
When I previously changed the hashing behavior in #11010, I neglected to consider the case where someone provides --hash=* to docker configure. My code assumed that a service name would always be passed in explicitly. This change uses all project service names in the absence of any provided name .

Related issue
Fixes #11145, thanks for pointing this out!

Signed-off-by: Matthew Walowski <mattwalowski@gmail.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, tests ok with --hash=* or --hash=serviceA,serviceB

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d9e0e42) 57.46% compared to head (bf26515) 57.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11146      +/-   ##
==========================================
- Coverage   57.46%   57.44%   -0.03%     
==========================================
  Files         129      129              
  Lines       11285    11288       +3     
==========================================
- Hits         6485     6484       -1     
- Misses       4170     4174       +4     
  Partials      630      630              
Files Coverage Δ
cmd/compose/config.go 33.13% <0.00%> (-0.60%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glours glours requested a review from ndeloof October 27, 2023 16:39
@ndeloof ndeloof merged commit 704a9fd into docker:main Oct 27, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] regression in v2.23.0: docker compose config --hash=* prints empty result
3 participants