Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump docker cli v1.25 beta1 #11247

Merged
merged 4 commits into from Dec 5, 2023
Merged

Bump docker cli v1.25 beta1 #11247

merged 4 commits into from Dec 5, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 5, 2023

What I did
same as #11246 with go.sum fixed

g0t4 and others added 3 commits December 4, 2023 11:27
@g0t4
update to v1.25 for RunAttach
0853283 
Signed-off-by: Wes Higbee <wes.mcclure@gmail.com>
@ndeloof
go mod tidy
cb929b6 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof
[lint] don't use deprecated types
5e898a3 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (ce1ddb6) 56.81% compared to head (5e898a3) 56.79%.

❗ Current head 5e898a3 differs from pull request most recent head 264b36d. Consider uploading reports for the commit 264b36d to get more accurate results

Files Patch % Lines
pkg/api/dryrunclient.go 0.00% 18 Missing ⚠️
pkg/compose/create.go 0.00% 9 Missing ⚠️
pkg/compose/attach.go 50.00% 1 Missing ⚠️
pkg/compose/convergence.go 75.00% 1 Missing ⚠️
pkg/compose/push.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11247      +/-   ##
==========================================
- Coverage   56.81%   56.79%   -0.03%     
==========================================
  Files         133      133              
  Lines       11512    11513       +1     
==========================================
- Hits         6541     6539       -2     
- Misses       4332     4334       +2     
- Partials      639      640       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndeloof ndeloof requested review from a team, glours and milas and removed request for a team December 5, 2023 10:12
@ndeloof ndeloof mentioned this pull request Dec 5, 2023
Closed
@ndeloof ndeloof requested review from a team and laurazard December 5, 2023 15:09
milas
milas approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of small comments

pkg/compose/create.go Outdated Show resolved Hide resolved
pkg/compose/logs_test.go Outdated Show resolved Hide resolved
@ndeloof
adopt container.RestartPolicy*
264b36d 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof enabled auto-merge (rebase) December 5, 2023 15:54
@ndeloof ndeloof merged commit 8026d0e into docker:main Dec 5, 2023
24 checks passed
@ndeloof ndeloof deleted the bump-docker-cli-v1.25-beta1 branch December 5, 2023 16:33
@dnhn dnhn mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milas milas milas approved these changes

@glours glours Awaiting requested review from glours glours was automatically assigned from docker/compose-maintainers

@laurazard laurazard Awaiting requested review from laurazard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndeloof @milas @g0t4