Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect services to build using WithServices #11255

Merged
merged 1 commit into from Dec 7, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 7, 2023

What I did
as we determine serviceToBeBuild we don't need to respect dependency order and get low benefit relying on concurrent goroutines execution. We can rely on simpler WithServices

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (bdbda79) 56.34% compared to head (1cf571f) 56.29%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/compose/convert.go 52.38% 9 Missing and 1 partial ⚠️
pkg/compose/create.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11255      +/-   ##
==========================================
- Coverage   56.34%   56.29%   -0.05%     
==========================================
  Files         134      134              
  Lines       11560    11564       +4     
==========================================
- Hits         6513     6510       -3     
- Misses       4407     4413       +6     
- Partials      640      641       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndeloof ndeloof marked this pull request as ready for review December 7, 2023 14:59
@ndeloof ndeloof requested review from a team, glours and milas and removed request for a team December 7, 2023 14:59
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof merged commit 5e61c62 into docker:main Dec 7, 2023
26 checks passed
@ndeloof ndeloof deleted the WithServices branch December 7, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants