Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): report more useful User-Agent on engine API requests #11333

Merged
merged 1 commit into from
Jan 11, 2024

Commits on Jan 10, 2024

  1. feat(cli): report more useful User-Agent on engine API requests

    When using the Moby/Docker Engine API client, we do not have a
    useful user agent value being reported. Ideally, in the future,
    the Docker CLI will set this appropriately for plugins when it
    initializes the client.
    
    For now, manually set it, which is a bit hacky because it
    requires some casting & manually invoking an option function
    that's technically meant for initialization. In practice, this
    is pretty safe - the cast is checked defensively and we ignore
    any errors (which shouldn't be possible anyway).
    
    Signed-off-by: Milas Bowman <milas.bowman@docker.com>
    milas committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b621948 View commit details
    Browse the repository at this point in the history