Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the resource timer after last expected event #11357

Merged
merged 1 commit into from Jan 16, 2024
Merged

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jan 16, 2024

What I did
Done event status doesn't mean the resource reached the expected status, it typically is first Created then Started and eventually Healthy. We need the TUI to be aware more events are expected and not stop the timer.

Related issue
fixes #11326

(not mandatory) A picture of a cute animal, if possible in relation to what you did
631631

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (2bf2b22) 56.74% compared to head (a4ddbcb) 56.56%.
Report is 14 commits behind head on main.

Files Patch % Lines
pkg/progress/tty.go 0.00% 4 Missing and 1 partial ⚠️
pkg/progress/noop.go 0.00% 1 Missing ⚠️
pkg/progress/quiet.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11357      +/-   ##
==========================================
- Coverage   56.74%   56.56%   -0.18%     
==========================================
  Files         134      136       +2     
  Lines       11448    11541      +93     
==========================================
+ Hits         6496     6528      +32     
- Misses       4330     4387      +57     
- Partials      622      626       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndeloof ndeloof requested review from a team, glours, milas and jhrotko and removed request for a team January 16, 2024 15:21
@ndeloof ndeloof marked this pull request as ready for review January 16, 2024 16:16
Copy link
Contributor

@jhrotko jhrotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@K2ouMais
Copy link

K2ouMais commented Apr 9, 2024

This seems to be broken again, after updating to Docker Desktop 4.29.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The initiated health check process is missing
4 participants