Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update link to use canonical URL for command #11359

Merged
merged 1 commit into from Jan 19, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Jan 16, 2024

What I did

docker/docs#19045 moves the CLI reference commands to their canonical locations instead of shorthand aliases. Updated the link to the docker events command to use URL of the canonical docker system events.

Related issue

We should wait for moby 25 before merging

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@dvdksn dvdksn force-pushed the docs-update-cli-reference-link branch from 472ef40 to 3341285 Compare January 19, 2024 10:34
@dvdksn dvdksn marked this pull request as ready for review January 19, 2024 10:34
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn force-pushed the docs-update-cli-reference-link branch from 3341285 to 053a560 Compare January 19, 2024 10:38
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35e262e) 56.55% compared to head (053a560) 56.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11359      +/-   ##
==========================================
- Coverage   56.55%   56.50%   -0.06%     
==========================================
  Files         136      136              
  Lines       11535    11535              
==========================================
- Hits         6524     6518       -6     
- Misses       4383     4389       +6     
  Partials      628      628              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvdksn
Copy link
Contributor Author

dvdksn commented Jan 19, 2024

hi @glours @ndeloof we'll need this one in for some refactoring we've done in the CLI reference docs in the moby v25 release. If you could take a look that would be great. cc @thaJeztah

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

I'll bring this one in 👍

@thaJeztah thaJeztah merged commit 3881690 into docker:main Jan 19, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants