chore(e2e): fix flaky test & standalone behavior #11382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was flaking in CI even though it was succeeding; I think there's a race with us killing and getting the output. Regardless, refactored so that it watches the process, which should make the test more reliable and faster. Additionally, I noticed that the standalone config was incorrect, so I (reset) the bool to the correct value to ensure we test things in plugin mode for E2E. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
glours
requested review from
a team,
ndeloof and
jhrotko
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This test was flaking in CI even though it was succeeding; I think there's a race with us killing and getting the output. Regardless, refactored so that it watches the process, which should make the test more reliable and faster.
Additionally, I noticed that the standalone config was incorrect, so I (reset) the bool to the correct value to ensure we test things in plugin mode for E2E.
Related issue
n/a
(not mandatory) A picture of a cute animal, if possible in relation to what you did
