Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce stopAndRemoveContainer to share logic scaling down #11393

Merged
merged 1 commit into from Jan 23, 2024

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jan 23, 2024

What I did
introduced stopAndRemoveContainer to share logic scaling down and removing container. To be used both by down and convergence.

Related issue
fixes #11391

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (143ac0f) 56.71% compared to head (0ef3601) 56.57%.

Files Patch % Lines
pkg/compose/down.go 68.18% 5 Missing and 2 partials ⚠️
pkg/compose/create.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11393      +/-   ##
==========================================
- Coverage   56.71%   56.57%   -0.15%     
==========================================
  Files         136      136              
  Lines       11547    11544       -3     
==========================================
- Hits         6549     6531      -18     
- Misses       4374     4388      +14     
- Partials      624      625       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndeloof ndeloof merged commit 1551fcb into docker:main Jan 23, 2024
26 checks passed
@ndeloof ndeloof deleted the stopAndRemoveContainer branch January 23, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker compose up --scale: when scale reduces, no actions are printed
2 participants