fix deadlock collecting large logs #11496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
large_logs_deadlock
branch
2 times, most recently
from
0d6efaa
to
f8c475e
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
large_logs_deadlock
branch
from
f8c475e
to
65c9466
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11496 +/- ##
==========================================
- Coverage 58.34% 58.32% -0.02%
==========================================
Files 136 136
Lines 11587 11590 +3
==========================================
Hits 6760 6760
- Misses 4166 4169 +3
Partials 661 661 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
re-implement log consumer concurrency using a stop-signal channel to prevent more events write after printer stopped.
The original issue is that we receive the container
dieevent while we still are processing a huge log, line by line. As a result the receiver already stopped processing events afterContainerEventExit, but the log writer still tries to write to channel, and has acquired the lock so is blocked on channel writeinspired by https://go101.org/article/channel-closing.html
Related issue
fixes #11493 (comment)
(not mandatory) A picture of a cute animal, if possible in relation to what you did