chore(watch): remove old docker cp
implementation
#11497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Remove the original
docker cp
implementation for Watch mode synchronization.This has not been the default for quite a while and required setting an environment variable to revert back.
The tar implementation is more performant and addresses several edge cases with the original
docker cp
version, so it's time to fully retire it.The scaffolding for multiple sync implementations remains to support future experimentation here.
Related issue
JIRA: COMP-385
(not mandatory) A picture of a cute animal, if possible in relation to what you did
![arctic fox in the snow](https://private-user-images.githubusercontent.com/841263/304506366-55b2727d-b014-433e-9e08-8a42b340f0f9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE4NjUyMDMsIm5iZiI6MTcyMTg2NDkwMywicGF0aCI6Ii84NDEyNjMvMzA0NTA2MzY2LTU1YjI3MjdkLWIwMTQtNDMzZS05ZTA4LThhNDJiMzQwZjBmOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyNFQyMzQ4MjNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kY2Y4ODYwNzA5ZDUyY2I5NTYxNDhjNDlhODk0MjhkYjljYWNmYTM3NmIwM2UxN2EyMGNiODE1MDhhOWU5ZDAxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.8QF4wn-dToEhaRQnvlI3wzoIVRQbx2fCI6Vt6ouT40U)