Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discard stdout for laaarge log test #11505

Merged
merged 1 commit into from Feb 15, 2024
Merged

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Feb 15, 2024

No description provided.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (8479c36) 58.41% compared to head (09446a9) 58.46%.
Report is 2 commits behind head on main.

Files Patch % Lines
cmd/compose/compose.go 28.00% 17 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11505      +/-   ##
==========================================
+ Coverage   58.41%   58.46%   +0.05%     
==========================================
  Files         134      134              
  Lines       11520    11533      +13     
==========================================
+ Hits         6729     6743      +14     
+ Misses       4131     4130       -1     
  Partials      660      660              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit c79aabd into docker:main Feb 15, 2024
26 checks passed
@ndeloof ndeloof deleted the laaarge_file_test branch February 15, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants