Double check watch pid if detected as still running on Windows #11513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
force-pushed
the
use-go-ps-pid-lock
branch
2 times, most recently
from
3fb5035
to
3e277fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11513 +/- ##
==========================================
+ Coverage 58.27% 58.40% +0.12%
==========================================
Files 134 135 +1
Lines 11546 11552 +6
==========================================
+ Hits 6729 6747 +18
+ Misses 4153 4143 -10
+ Partials 664 662 -2 ☔ View full report in Codecov by Sentry. |
glours
force-pushed
the
use-go-ps-pid-lock
branch
from
3e277fa
to
5150b52
Compare
False positives were detected when checking the previous watch process state Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
use-go-ps-pid-lock
branch
from
5150b52
to
9b0d1ff
Compare
glours
changed the title
glours
requested review from
a team,
ndeloof,
milas and
jhrotko
and removed request for
a team
ndeloof
reviewed
Feb 19, 2024
| @@ -0,0 +1,29 @@ | |||
| //go:build !windows | |||
There was a problem hiding this comment.
As this also applies to Darwin, maybe rename _posix 
ndeloof
approved these changes
Feb 19, 2024
jhrotko
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Use an another process management library to double check if the previous watch process is still running or if it's a false positive
Related issue
https://docker.atlassian.net/browse/COMP-25
fix #11066
(not mandatory) A picture of a cute animal, if possible in relation to what you did
