Apply --quiet-pull option when creating dependencies from run command #11523
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
requested review from
a team,
ndeloof,
milas and
jhrotko
and removed request for
a team
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
apply-quiet-pull-dependencies
branch
from
8c34ac5
to
cc5e170
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11523 +/- ##
==========================================
+ Coverage 58.27% 58.31% +0.03%
==========================================
Files 134 134
Lines 11546 11552 +6
==========================================
+ Hits 6729 6736 +7
+ Misses 4153 4151 -2
- Partials 664 665 +1 ☔ View full report in Codecov by Sentry. |
ndeloof
approved these changes
Feb 19, 2024
matt9ucci
added a commit
to matt9ucci/DockerCompletion
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
--quiet-pullflag wasn't pass to dependencies creation process.As a result pull logs of the dependency are displayed even if you explicitly activated
--quiet-pull.I also added the support of the
--quiet-pulloption to thecreatecommandRelated issue
#10714
(not mandatory) A picture of a cute animal, if possible in relation to what you did
