use a dedicated compose file for --quiet-pull e2e test #11537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
requested review from
a team,
ndeloof,
milas and
jhrotko
and removed request for
a team
ndeloof
approved these changes
Feb 21, 2024
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
fix-flakyness-run-quiet-pull
branch
from
19f5e67
to
697a48a
Compare
glours
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11537 +/- ##
==========================================
- Coverage 58.52% 58.27% -0.26%
==========================================
Files 134 134
Lines 11552 11552
==========================================
- Hits 6761 6732 -29
- Misses 4130 4155 +25
- Partials 661 665 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Use a different image for the
run --quiet-pulle2e test and be sure the image isn't pull concurrently by an another testRelated issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did