Fix volume merging #1160
Merged
Fix volume merging #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanand
force-pushed
the
fix-volume-merging
branch
2 times, most recently
from
ea82082
to
23dc4e7
Compare
| {'volumes': ['/bar:/code', '/data']}, | ||
| ) | ||
| self.assertEqual(set(service_dict['volumes']), set(['/bar:/code', '/data'])) | ||
|
|
There was a problem hiding this comment.
Normally this would be 6 separate tests, so the test names can describe the case that is being tested. It's not completely clear to which the difference between each of these without inspecting each in detail.
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand
force-pushed
the
fix-volume-merging
branch
from
23dc4e7
to
35c6e03
Compare
|
LGTM |
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Fix volume merging Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of silly mistakes in the volume merging code. Fixed, with regression tests.