Change menu information text to dim #11671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11671 +/- ##
==========================================
- Coverage 54.65% 54.64% -0.01%
==========================================
Files 145 145
Lines 12600 12601 +1
==========================================
Hits 6886 6886
- Misses 5018 5019 +1
Partials 696 696 ☔ View full report in Codecov by Sentry. |
jhrotko
force-pushed
the
change-menu-info-color
branch
from
953aeb9
to
549f1b1
Compare
ndeloof
reviewed
Mar 28, 2024
cmd/formatter/colors.go
Outdated
| @@ -37,7 +37,7 @@ var names = []string{ | |||
|
|
|||
| const ( | |||
| BOLD = "1" | |||
| FAINT = "2" | |||
| DIM = "2" | |||
There was a problem hiding this comment.
I always seen this one referred as "FAINT", as listed on https://en.wikipedia.org/wiki/ANSI_escape_code
There was a problem hiding this comment.
reverted the change
ndeloof
approved these changes
Mar 28, 2024
Signed-off-by: Joana Hrotko <joana.hrotko@docker.com>
jhrotko
force-pushed
the
change-menu-info-color
branch
from
549f1b1
to
422b46e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Change hard coded gray color to use dim code
\033[2minstead and let the terminal handle the dimming of the default color text.Related issue
fixes https://docker.atlassian.net/jira/software/c/projects/COMP/boards/576?selectedIssue=COMP-502
(not mandatory) A picture of a cute animal, if possible in relation to what you did
