Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open watch docs in up menu #11917

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

jhrotko
Copy link
Contributor

@jhrotko jhrotko commented Jun 18, 2024

What I did
Add Watch docs option in menu to open Watch documentation in Docker Desktop

Related issue

https://docker.atlassian.net/browse/COMP-624?atlOrigin=eyJpIjoiYWRhZDc0NzQ3YjU3NGQxYzg1Zjk0NWM0MDY2ZmQ1YmUiLCJwIjoiaiJ9

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@jhrotko jhrotko requested review from glours and ndeloof June 18, 2024 12:44
@jhrotko jhrotko self-assigned this Jun 18, 2024
@jhrotko jhrotko force-pushed the menu-tty-watch-helper branch 2 times, most recently from c69070a to ffbc204 Compare June 18, 2024 12:54
watchInfo = navColor(" ")
}
var isEnabled = " Enable"
if lk.Watch.Watching {
isEnabled = " Disable"
}
watchInfo = watchInfo + shortcutKeyColor("w") + navColor(isEnabled+" Watch")
return openDDInfo + openDDUI + watchInfo
return openDDInfo + openDDUI + watchInfo + openDDWatchDocs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add all openDD in order?

@@ -314,6 +333,8 @@ func (lk *LogKeyboard) HandleKeyEvents(event keyboard.KeyEvent, ctx context.Cont
lk.StartWatch(ctx, doneCh, project, options)
case 'o':
lk.openDDComposeUI(ctx, project)
case 'i':
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any objections with this shortcut? @glours @ndeloof

Signed-off-by: Joana Hrotko <joana.hrotko@docker.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhrotko jhrotko merged commit de478f8 into docker:main Jun 18, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants