Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dockerfile when building #1230

Closed
wants to merge 1 commit into from

Conversation

iffy
Copy link

@iffy iffy commented Mar 31, 2015

This is my feeble attempt at fixing this. The builds currently fail; I think because of an old version of docker-py. The required docker-py support was added by this: docker/docker-py@0713488 but I can't tell what version that is included in.

This is to fix issue #1228

The builds currently fail; I think because of an old version of docker-py
@iffy
Copy link
Author

iffy commented Mar 31, 2015

I didn't sign off the commit, apparently. Well... I'll leave this fix to someone else who is in the groove with this project.

@iffy iffy closed this Mar 31, 2015
@aanand
Copy link

aanand commented Mar 31, 2015

Thanks for the contribution! We're getting close with #1075, but there's some low-hanging fruit in #754 if you feel like adding support for something else.

For future reference, to sign off a commit:

git commit --signoff

To fix a commit that isn't signed off:

git commit --amend --reuse-message=HEAD --signoff

To push your fixed commit if you've already pushed the old one:

git push --force

@iffy
Copy link
Author

iffy commented Mar 31, 2015

Oh, it's a known issue being worked on :) That's good. And thanks for the signoff tip -- I'll do that for the next one. Would a programmatic future-proof way of doing #754 be possible? For example:

run-opts: "-foo -bar -whatever=who"

@aanand
Copy link

aanand commented Mar 31, 2015

Afraid that wouldn't work, since we don't shell out to docker run - we talk directly to the remote API.

There could be a key for directly setting extra properties on the container JSON, but we'd be opening the door to a lot of misuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants