New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SSL "CERTIFICATE_VERIFY_FAILED" error #1474
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ | |
import os | ||
import platform | ||
import subprocess | ||
import ssl | ||
|
||
|
||
def yesno(prompt, default=None): | ||
|
@@ -132,6 +133,7 @@ def get_version_info(scope): | |
elif scope == 'full': | ||
return versioninfo + '\n' \ | ||
+ "docker-py version: %s\n" % docker_py_version \ | ||
+ "%s version: %s" % (platform.python_implementation(), platform.python_version()) | ||
+ "%s version: %s\n" % (platform.python_implementation(), platform.python_version()) \ | ||
+ "OpenSSL version: %s" % ssl.OPENSSL_VERSION | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This broke python 2.6 compatiblity
which I guess is ok, we just need to remove it from tox.ini There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good - I don't think we need to support Python 2.6. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👏 👏 👏 |
||
else: | ||
raise RuntimeError('passed unallowed value to `cli.utils.get_version_info`') |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,13 @@ | ||
#!/bin/bash | ||
set -ex | ||
|
||
PATH="/usr/local/bin:$PATH" | ||
|
||
rm -rf venv | ||
virtualenv -p /usr/local/bin/python venv | ||
venv/bin/pip install -r requirements.txt | ||
venv/bin/pip install -r requirements-dev.txt | ||
venv/bin/pip install . | ||
venv/bin/pyinstaller -F bin/docker-compose | ||
mv dist/docker-compose dist/docker-compose-Darwin-x86_64 | ||
dist/docker-compose-Darwin-x86_64 --version | ||
dist/docker-compose-Darwin-x86_64 version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this added 4min to the jenkins build, which is unfortunate.
Could we use ubuntu vivid, which seems to have 2.7.9 (http://packages.ubuntu.com/vivid/python) ?
That way we could install from a package without having to build everything. I believe there was another PR for python3 support where @funkyfuture found that using ubuntu made things easier, but I forget the details of that now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is unfortunate, but hopefully it's temporary - if pyOpenSSL can fix its import-related oddities, hopefully it'll work with PyInstaller and we can go back to using the package.
The problem with using a newer distro is that it upgrades glibc, which is bad for compatibility with older distros.