Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Windows binary #1957

Merged
merged 3 commits into from Sep 21, 2015
Merged

Build Windows binary #1957

merged 3 commits into from Sep 21, 2015

Conversation

aanand
Copy link

@aanand aanand commented Sep 2, 2015

Interactive run is not supported.

@aanand aanand mentioned this pull request Sep 3, 2015
Closed
2 tasks
@dopry
Copy link

dopry commented Sep 3, 2015

I appreciate how this adapts my work from #1900, but doesn't provide attribution for my work.

@aanand
Copy link
Author

aanand commented Sep 3, 2015

@dopry Sorry about that - I've credited you in the commit.

@dopry
Copy link

dopry commented Sep 3, 2015

Thanks!

On Thu, Sep 3, 2015 at 2:19 PM, Aanand Prasad notifications@github.com
wrote:

@dopry https://github.com/dopry Sorry about that - I've credited you in
the commit.

—
Reply to this email directly or view it on GitHub
#1957 (comment).

Darrel O'Pry
The Spry Group, LLC.
http://www.spry-group.com
718-355-9767 x101

@wendal
Copy link

wendal commented Sep 7, 2015

+1

@bfirsh
Copy link

bfirsh commented Sep 8, 2015

cc @ahmetalpbalkan @friism does this work for you?

@ahmetb
Copy link

ahmetb commented Sep 8, 2015

@bfirsh idea LGTM as I said at #1900 (comment) as well.

@friism
Copy link

friism commented Sep 8, 2015

I haven't tried the build. This would be a great improvement though.

@alexandrev alexandrev mentioned this pull request Sep 13, 2015
Closed
@dnephin
Copy link

dnephin commented Sep 14, 2015

@aanand fyi #2037 seems to be related to this. Not sure how jsonschema handles paths in windows.

@alexandrev alexandrev mentioned this pull request Sep 15, 2015
Closed
@mnowster
Copy link

Python code LGTM.

I'm going to investigate #2037, which I don't think should block this PR.

@aanand
Stub 'run' on Windows
3e4182a 
Adapted from @dopry's work in docker#1900

Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
@aanand
Build Windows binary
4ae7f00 
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
@aanand
Catch WindowsError in call_silently
fb30498 
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
@msamblanet msamblanet mentioned this pull request Sep 18, 2015
Closed
@mnowster
Copy link

@dnephin the jsonschema path issue has now been fixed by #2068 so I think we're good to merge this, if it's a LGTM from you.

@dnephin dnephin added this to the 1.5.0 milestone Sep 21, 2015
@dnephin
Copy link

dnephin commented Sep 21, 2015

LGTM

mnowster added a commit that referenced this pull request Sep 21, 2015
@mnowster
Merge pull request #1957 from aanand/stub-run-on-windows
aa70209 
WIP: Build Windows binary
@mnowster mnowster merged commit aa70209 into docker:master Sep 21, 2015
@aanand aanand changed the title WIP: Build Windows binary Build Windows binary Sep 21, 2015
@aanand aanand mentioned this pull request Sep 21, 2015
Closed
@aanand aanand deleted the stub-run-on-windows branch September 21, 2015 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/packaging
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@aanand @dopry @wendal @bfirsh @ahmetb @friism @dnephin @mnowster