Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touchup "Extending services in Compose" #1993

Closed
wants to merge 1 commit into from

Conversation

charleswhchan
Copy link

(The rendered version, if it's easier for review:
https://github.com/charleswhchan/compose/blob/patch-2/docs/extends.md)

Signed-off-by: Charles Chan <charleswhchan@users.noreply.github.com>
@aanand
Copy link

aanand commented Sep 24, 2015

Thanks for the contribution!

In my opinion, this guide is going to need to change significantly as a result of #2051, since the process of configuring an app for multiple environments should now be simplified. Perhaps we should incorporate some of these changes when revising it.

@dnephin
Copy link

dnephin commented Oct 19, 2015

Ya, I'm about to start working on #2141 which will make significant changes to this section.

I'll cherry-pick this commit first and try and preserve some of the edits.

@charleswhchan
Copy link
Author

Thanks @dnephin.

@dnephin
Copy link

dnephin commented Nov 4, 2015

The new version is out. I tried to incorporate some of these changes. It did change pretty drastically, so I wasn't able to apply the cherry-pick, but hopefully the new version is better.

Thanks again for the PR!

@dnephin dnephin closed this Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants