Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for using multiple compose files #2290

Merged
merged 6 commits into from
Nov 3, 2015

Conversation

dnephin
Copy link

@dnephin dnephin commented Oct 29, 2015

Resolves #2141, #2289, also related to #1784 and #1786

cc @moxiegirl , @bfirsh

@@ -37,7 +37,7 @@ GITCOMMIT := $(shell git rev-parse --short HEAD 2>/dev/null)
default: docs

docs: docs-build
$(DOCKER_RUN_DOCS) -p $(if $(DOCSPORT),$(DOCSPORT):)8000 -e DOCKERHOST "$(DOCKER_DOCS_IMAGE)" hugo server --port=$(DOCSPORT) --baseUrl=$(HUGO_BASE_URL) --bind=$(HUGO_BIND_IP)
$(DOCKER_RUN_DOCS) -p $(if $(DOCSPORT),$(DOCSPORT):)8000 -e DOCKERHOST "$(DOCKER_DOCS_IMAGE)" hugo server --port=$(DOCSPORT) --baseUrl=$(HUGO_BASE_URL) --bind=$(HUGO_BIND_IP) --watch
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @SvenDowideit as well on this change. I'm pretty sure the old setup wasn't setting the correct volume path. With this I was able to see my changes immediately by just refreshing.

I hear hugo does livereload as well, but I don't see it injecting the livereload.js

@dnephin dnephin force-pushed the docs_multi_file_compose branch 2 times, most recently from 921f3ce to d688965 Compare October 30, 2015 17:23
@dnephin
Copy link
Author

dnephin commented Oct 30, 2015

Ok, "We" is now purged from the docs

@moxiegirl
Copy link

LGTM Thank you Daniel.

service, the local value either *override*s or *extend*s the definition of the
original service. This works differently for other configuration options.
If a configuration option is defined in both the original service the local
service, the local value *replaces* or *rextends* the original value.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "rextends"

@dnephin dnephin force-pushed the docs_multi_file_compose branch 2 times, most recently from 4c37a92 to f5b8c3f Compare November 2, 2015 20:14
Start restructuring extends docs in preparation for adding documentation about using multiple compose files.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
…e refreshed.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@aanand
Copy link

aanand commented Nov 3, 2015

LGTM

aanand added a commit that referenced this pull request Nov 3, 2015
Docs for using multiple compose files
@aanand aanand merged commit 4ebe68e into docker:master Nov 3, 2015
@dnephin dnephin deleted the docs_multi_file_compose branch November 3, 2015 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants