[cli / main] Support allocating ports at via run command #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Tiny bikeshed: could we make it And yeah, tests for |
|
We should really have |
|
Closing - replaced by #251 where I did less brain-dead things in my branching model. |
xulike666
pushed a commit
to xulike666/compose
that referenced
this pull request
Jan 19, 2017
Add ctr command line args `--runtime` and `--runtime-args` for multiple OCI runtime support. Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least for our use case, it's important to be able to run our main app environment in the foreground since we need to be able to throw "pdb"s in & actually capture the tty.
It doesn't look like there's currently tests around the "run" command, at least in the
CLITestCase- let me know if you would like me to implement those as part of this pull request.