Alias containers by short id #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
|
LGTM! |
aanand
added
status/5-cherry-pick
and removed
status/0-triage
status/3-docs-review
labels
|
Cherry-picked into #2753 |
|
|
||
| for network in self.networks: | ||
| if network in connected_networks: | ||
| self.client.disconnect_container_from_network( | ||
| container.id, network) |
There was a problem hiding this comment.
Do we need to join a network when we create it? or could we just have it join all the networks here?
There was a problem hiding this comment.
Yes, we need to set a NetworkMode or it'll default to bridge (and we'll just have to disconnect from that). I wondered about setting it to none, but it's then impossible to connect it to any networks.
There was a problem hiding this comment.
Good to know, thanks!
Might be worth making a feature request on engine for a way to accomplish this without connecting to a network originally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This necessitates a small change in how we connect to networks: rather than setting links and aliases for the one arbitrarily-picked network the container joins on creation, we disconnect and reconnect it immediately after creating it, so that we can set the short-id alias.
Closes #2702.