Constraint build argument types. Numbers are cast into strings. #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| build['args'] = resolve_build_args(build) | ||
| build['args'] = dict( | ||
| [(k, str(v)) for k, v in resolve_build_args(build).items()] | ||
| ) |
There was a problem hiding this comment.
Since we do this in a couple places, could we make this a function?
shin-
force-pushed
the
2927-buildargs-types
branch
from
ee187ea
to
ba25db6
Compare
Numerical driver_opts are also valid and typecast into strings. Additional config tests. Signed-off-by: Joffrey F <joffrey@docker.com>
shin-
force-pushed
the
2927-buildargs-types
branch
from
ba25db6
to
1952b52
Compare
| @@ -292,7 +293,7 @@ def load(config_details): | |||
| config_details = config_details._replace(config_files=processed_files) | |||
|
|
|||
| main_file = config_details.config_files[0] | |||
| volumes = load_mapping(config_details.config_files, 'get_volumes', 'Volume') | |||
| volumes = load_volumes(config_details.config_files) | |||
| networks = load_mapping(config_details.config_files, 'get_networks', 'Network') | |||
There was a problem hiding this comment.
I just noticed we have the same issue with network.driver_opts. Probably makes sense to fix it here as well?
Signed-off-by: Joffrey F <joffrey@docker.com>
|
Updated to include network |
|
LGTM |
shin-
added a commit
that referenced
this pull request
Feb 18, 2016
Constraint build argument types. Numbers are cast into strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numerical
driver_optsare also valid and typecast into strings.FIxes #2927