Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isolation parameter to v3 compose file schema (fixes #5069). #5075

Closed
wants to merge 1 commit into from

Conversation

Techwolfy
Copy link

Fix for isolation parameter errors in v3+ compose files.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "master" git@github.com:Techwolfy/compose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Daniel Ring <t-darin@microsoft.com>
@shin-
Copy link

shin- commented Aug 2, 2017

As I explained in #5069 (comment), we can not make this change unless it is an available option for Swarm services. Moreover, the v3 spec should be modified on the docker/cli repo first then reproduced here - not the other way around.

@shin- shin- closed this Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants