Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an explicit no-op option for minimal containers that do not have echo #516

Closed
wants to merge 2 commits into from
Closed

Add an explicit no-op option for minimal containers that do not have echo #516

wants to merge 2 commits into from

Conversation

vizowl
Copy link

@vizowl vizowl commented Oct 3, 2014

In order to support data only volumes using minimal images #514 I have added an option that allows a no-op command to be explicitly specified - currently it is assumed to be echo which isn't necessarily available on a minimal image.

I have added a test and updated the documentation.

I am concerned that this approach essentially exposes an internal feature ...

Christopher Knox added 2 commits October 3, 2014 11:30
@vizowl
Copy link
Author

vizowl commented Oct 3, 2014

I messed up the code signoff so I will create a new pull request with a rebased commit ...

@vizowl vizowl closed this Oct 3, 2014
@aanand aanand mentioned this pull request Nov 20, 2014
@defunctzombie
Copy link

Was there a new PR for this? This issue still persists.

@vizowl
Copy link
Author

vizowl commented Dec 11, 2014

I only closed this pull request because I messed up the commit signing - there was another pull request here #517 which generated a lot of discussion but no solution. I just stopped using minimal containers for data only volumes ...

@saulshanabrook
Copy link

@vizowl Could I open a new PR with your code and sign off of it? I would love to GTM.

@saulshanabrook
Copy link

If anyone else if having this problem, you can use the cogniteev/echo image instead of tianon/true which was created expressly to work around this bug.

@aanand
Copy link

aanand commented Apr 17, 2015

@saulshanabrook A preferred solution would be the one proposed in #874 - use container renaming so we don't have to have intermediate containers at all.

saulshanabrook added a commit to canada-nyc/django-canadanewyork that referenced this pull request Apr 17, 2015
Docker-compose requires images to have teh "echo" command, which the `true` image doesn't so use a different minimal image that has this command.

workaround for docker/compose#516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants