Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate the value of the env file vars. #6212

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@wfender
Copy link
Contributor

wfender commented Sep 21, 2018

I propose this fix. It does not address the multiline problem cause to me it should be a new feature but at least it will allow to use new line and other stuff like this in env file.

Signed-off-by: Fender William fender.william@gmail.com

Resolves #3527

Evaluate the value of the env file vars.
Signed-off-by: Fender William <fender.william@gmail.com>
@shin-

This comment has been minimized.

Copy link
Contributor

shin- commented Sep 21, 2018

Thanks @wfender !

Looks like this broke unicode support (see test failures). As far as I can tell, it also misses the point Aanand made here which is that changes to env_file handling should happen upstream in moby/moby first, otherwise we're introducing a confusing discrepancy between Docker and Compose.

Evaluate only double quoted value
Signed-off-by: Fender William <fender.william@gmail.com>
@wfender

This comment has been minimized.

Copy link
Contributor Author

wfender commented Sep 25, 2018

Hi @shin-
It wasn't the unicode support but just a warning that I've add ;) and i reduce the scope to evaluate only a double quoted value.

Like many others I'm disappointed that such basic problem could not be solved for so long time.
For moby, the issue is closed and will not be treated despite the many requests.
Unfortunately on the side of moby the discussions about an .env2 file doesn't seem conclusive and i think it's not the place to develop an .env2 file.

So like the 50+ comments I think we could at least evaluate the double quoted values and that will probably help the many people who do not benefit from swarm mode. (docker secret ...) for certificates managment and other kind of variables.
Otherwise if we want the problem to be solved on the docker engine side (and I'll understand that we don't want to create confusion with the engine support ) then why not close this discussion and send back to moby/moby.
Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.