Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker version to 18.09.3 #6561

Closed
wants to merge 1 commit into from
Closed

Update Docker version to 18.09.3 #6561

wants to merge 1 commit into from

Conversation

joakimr-axis
Copy link

Change-Id: I1ac2a617f03443b9f7327dcddcde4af8275e32e0
Signed-off-by: Joakim Roubert joakimr@axis.com

Resolves #6560

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "updatedocker" git@github.com:joakimr-axis/compose.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842357817216
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Change-Id: I1ac2a617f03443b9f7327dcddcde4af8275e32e0
Signed-off-by: Joakim Roubert <joakimr@axis.com>
@tbeadle
Copy link

tbeadle commented Apr 9, 2019

+1 This would be good for us so that we can easily use buildkit from within the docker-compose image.

@@ -1,4 +1,4 @@
FROM docker:18.06.1 as docker
FROM docker:18.09.3 as docker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that 18.09.4 is now released; alternatively, use 18.09, which would always be the latest patch release of Docker 18.09

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18.09.3 was the latest release when this was created. If I update it to 18.09.4 and nothing happens still with the patch we will see 18.09.5 or something superseding. Using 18.09 as suggested would implicate I could not actually guarantee that my patch was tested with the version that 18.09 is currently pointing towards. Perhaps the latter is not considered an issue.
I will see if any of the maintainers step in and have suggestions on how they would like this (if they do at all).

@chris-crone
Copy link
Member

Thanks for the PR @joakimr-axis.

@ulyssessouza is reworking the Dockerfiles for this project so this is superseded by: #6641

@joakimr-axis joakimr-axis deleted the updatedocker branch April 23, 2019 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants