Add dependencies for ARM build #6908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
approved these changes
Sep 23, 2019
|
Will this mean there will be armv8 and armv7 images posted to dockerhub or are we supposed to build these ourselves? |
thaJeztah
reviewed
Oct 1, 2019
|
@StefanScherer can you please address Sebastiaan's comment? Can then be merged |
Signed-off-by: Stefan Scherer <scherer_stefan@icloud.com>
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
StefanScherer
force-pushed
the
add-dependencies-for-arm-build
branch
from
cdda799
to
ce52f59
Compare
|
Tried on Odroid H2 armv7 ubuntu 16. Worked flawlessly! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing dependencies if someone tries to build docker-compose on an ARM device like the Raspberry Pi. It seems these dependencies are implicit installed while building on amd64, but need to be installed on arm.
Prerequisites
How to verify
git clone https://github.com/docker/composecd composescripts/build/linuxdist/docker-compose-Linux-armv7l --versionHelps #6831