Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run action to respect COMPOSE_IGNORE_ORPHANS environment variable #7020

Closed
wants to merge 1 commit into from

Conversation

vaab
Copy link

@vaab vaab commented Nov 14, 2019

It seems that COMPOSE_IGNORE_ORPHANS is not checked when using compose run which is quite cumbersome : people are more likely to use compose run for run-once CLI scripts and would then care about the outputs (stdout and stderr), they might not want to see warning about orphans poping out.

As I was not sure this was something you might want, tell me if I need to write tests or documentation.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "run_ignore_orphans" git@github.com:0k/compose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Valentin Lab <valentin.lab@kalysto.org>
@ndeloof
Copy link
Contributor

ndeloof commented Nov 18, 2019

Seems legitimate to me and not a risky change.

@ulyssessouza ulyssessouza self-requested a review January 9, 2020 13:21
Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @vaab ! Thank you for the contribution!
Could you please add tests to your PR?

@redcinelli
Copy link

Hello @vaab ! Thank you for the contribution!
Could you please add tests to your PR?

I am keen on taking on the testing, but @ulyssessouza could you please help me out.

What should we be testing ? Some test on the project.up() already exist with the ignore_orphans set to either values.
And I don't think you want us to test toplevel_environment.get_boolean('COMPOSE_IGNORE_ORPHANS')

So I feel this behavior is already covered.
Which makes me a bit confused. 😅

@Wirone
Copy link

Wirone commented Nov 25, 2021

Can't believe it's still open after 2 years 🤯

PIG208 added a commit to PIG208/compose that referenced this pull request Jan 13, 2022
This revives docker#7020 and resolves the issue mentioned in docker#4992.
PIG208 added a commit to PIG208/compose that referenced this pull request Jan 13, 2022
This revives docker#7020 and resolves the issue mentioned in docker#4992.

Signed-off-by: Zixuan James Li <359101898@qq.com>
PIG208 added a commit to PIG208/compose that referenced this pull request Jan 13, 2022
This revives docker#7020 and resolves the issue mentioned in docker#4992.

Signed-off-by: Zixuan James Li <359101898@qq.com>
PIG208 added a commit to PIG208/compose that referenced this pull request Mar 3, 2022
This revives docker#7020 and resolves the issue mentioned in docker#4992.

Signed-off-by: Zixuan James Li <359101898@qq.com>
PIG208 added a commit to PIG208/compose that referenced this pull request Mar 4, 2022
This revives docker#7020 and resolves the issue mentioned in docker#4992.

Signed-off-by: Zixuan James Li <359101898@qq.com>
ndeloof pushed a commit that referenced this pull request Mar 5, 2022
This revives #7020 and resolves the issue mentioned in #4992.

Signed-off-by: Zixuan James Li <359101898@qq.com>
ulyssessouza pushed a commit that referenced this pull request Mar 28, 2022
This revives #7020 and resolves the issue mentioned in #4992.

Signed-off-by: Zixuan James Li <359101898@qq.com>
debdutdeb pushed a commit to debdutdeb/compose that referenced this pull request Jun 30, 2022
This revives docker#7020 and resolves the issue mentioned in docker#4992.

Signed-off-by: Zixuan James Li <359101898@qq.com>
@glours
Copy link
Contributor

glours commented Jul 27, 2022

Thanks for taking the time to create this issue/pull request!

Unfortunately, Docker Compose V1 has reached end-of-life and we are not accepting any more changes (except for security issues). Please try and reproduce your issue with Compose V2 or rewrite your pull request to be based on the v2 branch and create a new issue or PR with the relevant Compose V2 information.

@glours glours closed this Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants