New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix run
action to respect COMPOSE_IGNORE_ORPHANS environment variable
#7020
Conversation
Please sign your commits following these rules: $ git clone -b "run_ignore_orphans" git@github.com:0k/compose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Valentin Lab <valentin.lab@kalysto.org>
9e4f3a0
to
f13bc7d
Compare
Seems legitimate to me and not a risky change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @vaab ! Thank you for the contribution!
Could you please add tests to your PR?
I am keen on taking on the testing, but @ulyssessouza could you please help me out. What should we be testing ? Some test on the So I feel this behavior is already covered. |
Can't believe it's still open after 2 years 🤯 |
This revives docker#7020 and resolves the issue mentioned in docker#4992.
This revives docker#7020 and resolves the issue mentioned in docker#4992. Signed-off-by: Zixuan James Li <359101898@qq.com>
This revives docker#7020 and resolves the issue mentioned in docker#4992. Signed-off-by: Zixuan James Li <359101898@qq.com>
This revives docker#7020 and resolves the issue mentioned in docker#4992. Signed-off-by: Zixuan James Li <359101898@qq.com>
This revives docker#7020 and resolves the issue mentioned in docker#4992. Signed-off-by: Zixuan James Li <359101898@qq.com>
This revives docker#7020 and resolves the issue mentioned in docker#4992. Signed-off-by: Zixuan James Li <359101898@qq.com>
Thanks for taking the time to create this issue/pull request! Unfortunately, Docker Compose V1 has reached end-of-life and we are not accepting any more changes (except for security issues). Please try and reproduce your issue with Compose V2 or rewrite your pull request to be based on the v2 branch and create a new issue or PR with the relevant Compose V2 information. |
It seems that
COMPOSE_IGNORE_ORPHANS
is not checked when usingcompose run
which is quite cumbersome : people are more likely to usecompose run
for run-once CLI scripts and would then care about the outputs (stdout and stderr), they might not want to see warning about orphans poping out.As I was not sure this was something you might want, tell me if I need to write tests or documentation.