Introduce "cp" command #7029
Closed
Introduce "cp" command #7029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to mimic `docker cp` UX but using service abstraction delegates to the actual docker cp command once target container has been resolved Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
compose/cli/utils.py
Outdated
| if not os.path.isabs(path) and not path.startswith('.'): | ||
| parts = path.split(":", 2) | ||
| if len(parts) == 2: | ||
| return (parts[0], parts[1]) |
There was a problem hiding this comment.
Suggested change
| return (parts[0], parts[1]) | |
| return parts[0], parts[1] |
joseangel-sc
approved these changes
Nov 20, 2019
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> Co-Authored-By: Ulysses Souza <ulysses.souza@docker.com> Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
|
Hi, what is the status of this pull request? can it be merged to master as part of next docker-compose version? |
|
This is just a proposal.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to mimic
docker cpUX but using service abstractiondelegates to the actual docker cp command once target container has been
resolved
Mostly to check interest by maintainers, or maybe we should just reject #5523 and document workaround.