Implement -f / --file argument in container-script #7099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glance-
requested review from
ndeloof,
rumpl and
ulyssessouza
as code owners
|
Please sign your commits following these rules: $ git clone -b "container-script-file-argument" git@github.com:glance-/compose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
When using -f / --file argument to container-script, and pointing it to some path which isn't beneath cwd or home, the call would have failed previously, like: $ docker-compose -f /tmp/docker-compose.yml up ERROR: .FileNotFoundError: [Errno 2] No such file or directory: '/tmp/docker-compose.yml' After this patch: $ docker-compose -f /tmp/docker-compose.yml up Creating tmp_alpine_1 ... done Attaching to tmp_alpine_1 tmp_alpine_1 exited with code 0 It also aborts the parsing at docker-compose verbs so it doesn't confuse docker-compose args with anything thats ment for a command in the container: $ docker-compose -f /tmp/docker-compose.yml run alpine echo --file /tmp/kex.xml --file /tmp/kex.xml Signed-off-by: Anton Lundin <glance@acc.umu.se>
glance-
force-pushed
the
container-script-file-argument
branch
from
39190d5
to
3357180
Compare
glance-
pushed a commit
to glance-/puppet-sunet
that referenced
this pull request
Dec 18, 2019
This way, we won't try to mount any container arguments into the docker-compose container, or anything else weird. This also adds support for the --file= syntax which didn't work before. This change is proposed to upstream as: docker/compose#7099
glance-
pushed a commit
to glance-/puppet-sunet
that referenced
this pull request
Dec 18, 2019
This way, we won't try to mount any container arguments into the docker-compose container, or anything else weird. This also adds support for the --file= syntax which didn't work before. This change is proposed to upstream as: docker/compose#7099
|
Thanks for taking the time to create this issue/pull request! Unfortunately, Docker Compose V1 has reached end-of-life and we are not accepting any more changes (except for security issues). Please try and reproduce your issue with Compose V2 or rewrite your pull request to be based on the v2 branch and create a new issue or PR with the relevant Compose V2 information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using -f / --file argument to container-script, and pointing it to
some path which isn't beneath cwd or home, the call would have failed
previously, like:
$ docker-compose -f /tmp/docker-compose.yml up
ERROR: .FileNotFoundError: [Errno 2] No such file or directory: '/tmp/docker-compose.yml'
After this patch:
$ docker-compose -f /tmp/docker-compose.yml up
Creating tmp_alpine_1 ... done
Attaching to tmp_alpine_1
tmp_alpine_1 exited with code 0
It also aborts the parsing at docker-compose verbs so it doesn't
confuse docker-compose args with anything thats ment for a command in
the container:
$ docker-compose -f /tmp/docker-compose.yml run alpine echo --file /tmp/kex.xml
--file /tmp/kex.xml