Consider "Ignore pull failure" option when running pull in parallel #7134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just need a test |
|
Can we get this one merged? 😄 |
|
Merge please. |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
|
Any updates on this? I would love to upgrade the docker-compose version we are using, but we are blocked on not having ignore-pull-failures available on parallel pull. |
|
with this behavior our services can't restart when our docker registry is down but the images would still exists local so it would be possible to just start it, but the systemd unit fails at pulling pre step because --ignore-pull-failures is not working (even not in combination with --no-parallel) in version 1.27.4 please merge this to get rid of this.. |
|
Bump. Could someone please look into this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #7127