support specifying a tar file as context #7283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelKim0407
requested review from
ndeloof,
rumpl and
ulyssessouza
as code owners
MichaelKim0407
force-pushed
the
build-from-tar
branch
from
e88bb08
to
d05a9f0
Compare
Signed-off-by: Zheng Jin <zjin@grokstream.com>
MichaelKim0407
force-pushed
the
build-from-tar
branch
from
d05a9f0
to
5185668
Compare
added 2 commits
March 12, 2020 10:33
Signed-off-by: Zheng Jin <zjin@grokstream.com>
Signed-off-by: Zheng Jin <zjin@grokstream.com>
|
is there a proper way to "bump" this? would love this feature. and I see that #1209 was recently closed for staleness. |
|
Compose v1 is EoL, compose v2 codebase should be considered for new features |
|
Thanks for taking the time to create this issue/pull request! Unfortunately, Docker Compose V1 has reached end-of-life and we are not accepting any more changes (except for security issues). Please try and reproduce your issue with Compose V2 or rewrite your pull request to be based on the v2 branch and create a new issue or PR with the relevant Compose V2 information. |
|
Lol this PR was opened more than 2 years ago. I'm not sure if I want to spend the effort to create another one if this is how it works here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1209
Implemented the support for both docker-py and cli build. Very minimal changes were required since both docker-py and cli already support the behavior.
I probably need to add tests and documentation somewhere, which I haven't done yet. If anyone can point me to the correct locations, I'll be happy to add them