Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix 7242 docker-compose with buildkit does not insert container labels #7328

Merged
merged 1 commit into from Mar 31, 2020

Conversation

luHub
Copy link

@luHub luHub commented Mar 28, 2020

Resolves #7242

This issue solves bug reported by issue 7242
where labels are not present when using _CLIBuilder.

This merge request contains:

  • Fix
  • Integration test that checks for labels when the _CLIBuilder is used

Signed-off-by: luHub <lucioguerchi16f@gmail.com>
Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

PTAL @thaJeztah

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ulyssessouza
Copy link
Contributor

Thank you @luHub !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-compose with buildkit does not insert container labels
3 participants