Use ssh client by default #7872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiordache
requested review from
ndeloof,
rumpl and
ulyssessouza
as code owners
chris-crone
reviewed
Oct 20, 2020
aiordache
force-pushed
the
use_ssh_client
branch
4 times, most recently
from
c0ed526
to
9aa2f7f
Compare
Signed-off-by: aiordache <anca.iordache@docker.com>
aiordache
force-pushed
the
use_ssh_client
branch
from
9aa2f7f
to
e28c948
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, shell out to the ssh client for an ssh connection as the paramiko connection is sometimes unreliable.
The
requirements.txtmust be updated once we have a release of docker-py with the ssh client support.Depends on docker/docker-py#2691