Add Snyk scan suggestion when building #8247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyssessouza
force-pushed
the
scan-suggestion
branch
from
b7b86c8
to
5773a11
Compare
thaJeztah
reviewed
Apr 1, 2021
ulyssessouza
force-pushed
the
scan-suggestion
branch
3 times, most recently
from
ecdd442
to
de63ae2
Compare
gtardif
reviewed
Apr 1, 2021
ulyssessouza
force-pushed
the
scan-suggestion
branch
from
de63ae2
to
974ac94
Compare
gtardif
approved these changes
Apr 1, 2021
gtardif
suggested changes
Apr 2, 2021
There was a problem hiding this comment.
Actually building & testing the branch, I don't manage to see the scan suggest message on mac or windows.
I suppose this is because you expect the optin field to be defined in the config json file, by default after desktop install this config fileexist but does not have the field defined, it gets defined only after a first run of docker scan. This is when the scan suggest message should be displayed, where optin is not present in the config json
ulyssessouza
force-pushed
the
scan-suggestion
branch
from
974ac94
to
42c55e6
Compare
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
ulyssessouza
force-pushed
the
scan-suggestion
branch
from
42c55e6
to
e496c64
Compare
gtardif
approved these changes
Apr 6, 2021
aiordache
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/docker/dev-tooling-team/issues/286