Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot setup IPAM gateway #9363

Merged
merged 1 commit into from
Apr 24, 2022

Conversation

qnap-ericfan
Copy link
Contributor

@qnap-ericfan qnap-ericfan commented Apr 7, 2022

What I did
Here is my docker-compose-yaml

services:
  test:
    image: nginx
    networks:
      - br-test

networks:
  br-test:
    driver: bridge
    ipam:
      config:
        - subnet: 172.17.4.0/24
          gateway: 172.17.4.1

I execute command docker-compose up, then I inspect br-test network.
But IPAM gateway doesn't be setup correctly.

[
    {
       ...
        "IPAM": {
            "Driver": "default",
            "Config": [
                {
                    "Subnet": "172.17.4.0/24"
                }
            ]
        }
        ...
    }
]

Related issue
fixes #9330

(not mandatory) A picture of a cute animal, if possible in relation with what you did

Signed-off-by: Eric Fan <ericfan@qnap.com>
@blop
Copy link

blop commented Apr 23, 2022

@qnap-ericfan Thank you for the PR !
I have the same issue, hope this get merged soon ;-)

I'll try to build from your branch in the meantime.

@blop
Copy link

blop commented Apr 23, 2022

Related to #8742 and #9330

@gaby
Copy link

gaby commented Apr 23, 2022

Hopefully this gets merged... We are still stuck in v1.29 because of IPAM issues.

@potiuk
Copy link

potiuk commented Apr 23, 2022

Would be GREAT!

@gaby
Copy link

gaby commented Apr 24, 2022

@ndeloof @gtardif @ulyssessouza @rumpl Can someone take a look at this PR. Without proper IPAM support it's impossible to migrate to docker-compose v2 Thanks!

@ndeloof ndeloof enabled auto-merge (rebase) April 24, 2022 07:49
Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ndeloof ndeloof disabled auto-merge April 24, 2022 15:30
@ndeloof ndeloof merged commit 41b3967 into docker:v2 Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support IPAM options
6 participants