Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect image ID after pull to se com.docker.compose.image #9366

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Apr 8, 2022

What I did
After image has been pulled, inspect image to get local ID (unfortunately pull API doesn't expose this data) and set com.docker.compose.image accordingly. Otherwise a second up will consider container has diverged for unexpected image ID

Related issue
closes #9357

(not mandatory) A picture of a cute animal, if possible in relation with what you did
image
(Grillon taupe)

@ndeloof ndeloof force-pushed the image_label_after_pull branch 3 times, most recently from 72ba0a6 to 6aa036f Compare April 8, 2022 12:13
@ndeloof ndeloof force-pushed the image_label_after_pull branch 4 times, most recently from d21715b to 5082210 Compare April 13, 2022 16:07
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 00fd1c1 into docker:v2 Apr 21, 2022
@ndeloof ndeloof deleted the image_label_after_pull branch April 21, 2022 20:42
@benlangfeld
Copy link

@ndeloof @ulyssessouza This did not fix the issue reported in #9357. The issue is still present in Compose v2.6.0.

@ulyssessouza
Copy link
Contributor

@benlangfeld could you please try with the latest version? (At the time of this comment it's 2.10.1)

@benlangfeld
Copy link

@ulyssessouza I did. It's still broken.

@benlangfeld
Copy link

@ulyssessouza Can we please re-open #9357? It was erroneously closed as fixed by this change, but that is not true and the bug still stands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container needlessly recreated and then won't start on docker-compose up
4 participants