New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if command is ran with a compose file, apply the compose model #9375
Conversation
901a2f6
to
97eb94e
Compare
cmd/compose/down.go
Outdated
@@ -62,7 +61,7 @@ func downCommand(p *projectOptions, backend api.Service) *cobra.Command { | |||
ValidArgsFunction: noCompletion(), | |||
} | |||
flags := downCmd.Flags() | |||
removeOrphans := utils.StringToBool(os.Getenv("COMPOSE_REMOVE_ORPHANS ")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder this ever worked before?
2da3a4d
to
219ab20
Compare
I fixed the merge conflicts and added some of the tests I'd already written for the other PR, this one covers the other use case and applies the same logic to other commands 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Ahh! Need to fix some tests 😅 |
3a7e5dd
to
df9f739
Compare
…ust project name Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
df9f739
to
be495ab
Compare
While looking into why this was failing when applying a similar logic to The reason why some tests were failing was that we are running I think we should handle these in the same way, probably in the parent I made some changes to |
Why would you like the latter to fail? IMHO once |
I worded that weirdly 😅 don’t want it to fail, but with the changes before my last commit it was failing. This was due to |
LGTM with @laurazard additions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
25d11cf
to
c586ca4
Compare
What I did
pass project to start/restart/pause/unpause if user ran command with a compose.yaml file, not just project-name
backend will then apply model (active profiles) and not consider all resources with project label
Related issue
see #9286
Fixes #9705
Fixes #9671
(not mandatory) A picture of a cute animal, if possible in relation with what you did