-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add e2e tests to verify env variables priority #9499
Conversation
080bf07
to
5a4a1e3
Compare
@glours I think we should include test cases regarding to those issues as well |
e87c121
to
2fcf6fc
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I really like seeing all this behavior tested e2e, and the tests are pretty clear 👍
2fcf6fc
to
1ed6a73
Compare
LGTM, waiting for compose-go release then to update go.mod accordingly |
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
1ed6a73
to
a1b3f95
Compare
What I did
Don't override compose environment values with os ones.
Add end to end tests to ensure we won't have regression on environments variables priority
(not mandatory) A picture of a cute animal, if possible in relation with what you did
![image](https://user-images.githubusercontent.com/705411/170079091-dbce395f-a642-44df-ac4d-f432a8c76fdc.png)