add e2e tests to verify env variables priority #9499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
force-pushed
the
add-envs-e2e-tests
branch
from
080bf07
to
5a4a1e3
Compare
|
@glours I think we should include test cases regarding to those issues as well |
glours
force-pushed
the
add-envs-e2e-tests
branch
3 times, most recently
from
e87c121
to
2fcf6fc
Compare
|
|
laurazard
approved these changes
May 30, 2022
glours
force-pushed
the
add-envs-e2e-tests
branch
from
2fcf6fc
to
1ed6a73
Compare
|
LGTM, waiting for compose-go release then to update go.mod accordingly |
maxcleme
approved these changes
May 30, 2022
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
glours
force-pushed
the
add-envs-e2e-tests
branch
from
1ed6a73
to
a1b3f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Don't override compose environment values with os ones.
Add end to end tests to ensure we won't have regression on environments variables priority
(not mandatory) A picture of a cute animal, if possible in relation with what you did
