Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#9597) feat: add boolean type #9598

Closed
wants to merge 1 commit into from
Closed

(#9597) feat: add boolean type #9598

wants to merge 1 commit into from

Conversation

seunggabi
Copy link

Signed-off-by: seunggabi <seunggabi@naver.com>
@glours
Copy link
Contributor

glours commented Jun 27, 2022

@seunggabi the python version of Compose is going to be end of life in few months, we won't merge any PRs except security ones.
Can you give a try to Compose V2 (the go version)?

@seunggabi
Copy link
Author

seunggabi commented Jun 27, 2022

@glours
ok got it

let me try & make code

@thaJeztah
Copy link
Member

@glours I'm slightly confused about these other types for this option, given that logging-driver options only accept strings; also see https://docs.docker.com/config/containers/logging/configure/

Note

log-opts configuration options in the daemon.json configuration file must be provided as strings. Boolean and numeric values (such as the value for max-file in the example above) must therefore be enclosed in quotes (").

Or does compose convert these options back to a string? My concern in that case would be that (e.g.) yes would be considered a boolean in YAML, but may have been intended to be a literal "yes" (string); here's a list of values that are considered a boolean when working with YAML; https://yaml.org/type/bool.html

Regexp:
     y|Y|yes|Yes|YES|n|N|no|No|NO|true|True|TRUE|false|False|FALSE|on|On|ON|off|Off|OFF

I'm wondering what compose will send as option for that (e.g. it may convert yes to a boolean true, and then set it as "true" (string) for the container?

@seunggabi
Copy link
Author

@thaJeztah

https://yaml.org/type/bool.html is old yaml 1.1
please read yaml 1.2.2

#9596

@seunggabi
Copy link
Author

seunggabi commented Jun 27, 2022

it's works boolean on docker compose v2
so this pr don't need... haha ..TT

@glours thx

I closed this pr ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants