Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docs): use push-to-fork when creating pr #9670

Merged
merged 1 commit into from Jul 22, 2022

Conversation

crazy-max
Copy link
Member

follow-up docker/buildx#1184

increase security so docker-tools-robot does not need write access on docker/docker.github.io and will push to its own fork at https://github.com/docker-tools-robot/docker.github.io and create the PR from it.

unfortunately we can't set the label anymore as it requires admin rights but I think it's fine:

  Applying labels 'area/Build'
  Error: Must have admin rights to Repository.

other advantage is it will not pollute docker/docker.github.io with other branches.

cc @glours

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@crazy-max
Copy link
Member Author

ci issue unrelated: https://github.com/docker/compose/runs/7469589600?check_suite_focus=true#step:5:89

run golangci-lint
  Running [/home/runner/golangci-lint-1.47.2-linux-amd64/golangci-lint run --out-format=github-actions --timeout=180s] in [] ...
  Error: `addSecretsConfig` - `sessionConfig` is unused (unparam)
  
  level=warning msg="[linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
  
  Error: issues found

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours enabled auto-merge July 22, 2022 15:56
@glours glours merged commit 60621dc into docker:v2 Jul 22, 2022
@crazy-max crazy-max deleted the docs-workflow-fork branch July 22, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants