New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra whitespaces in help text of some subcommands #9710
Conversation
Thank you for contributing! It appears your commit message is missing a DCO sign-off, We require all commit messages to have a
There is no need to open a new pull request, but to fix this (and make CI pass), Unfortunately, it's not possible to do so through GitHub's web UI, so this needs You can find some instructions in the output of the DCO check (which can be found Steps to do so "roughly" come down to:
Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions! |
bb776d7
to
6e52cfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The change itself looks good to me, let me start CI to verify if the docs also need to be regenerated (not sure if it strips the whitespace when generating the markdown files); you can re-generate the docs with make docs
Looks like I will need to update the markdown docs as well |
Signed-off-by: Khoa Le <ltkhoa2711@gmail.com>
6e52cfe
to
7b20fdf
Compare
@thaJeztah I've updated the docs as well. Another CI trigger approval would be appreciated. Thanks! |
Awesome, thanks! (triggered CI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (not a maintainer, so "non-binding" 😅)
Remove superfluous whitespaces Signed-off-by: Khoa Le <ltkhoa2711@gmail.com>
What I did
A relatively small and simple change to just remove extra leading whitespaces in help text of the
run
anddown
subcommands.What it currently looks like before the change (note the second last line):
Related issue
I didn't create an issue since this is a relatively small.
(not mandatory) A picture of a cute animal, if possible in relation with what you did