Pull image regardless of whether it exists locally if tag=latest
#9781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurazard
force-pushed
the
pull-image-latest
branch
from
6ab8bee
to
02ae480
Compare
... and pull policy is `missing` or `if_not_present` Signed-off-by: Laura Brehm <laurabrehm@hey.com>
laurazard
force-pushed
the
pull-image-latest
branch
from
02ae480
to
2357348
Compare
laurazard
commented
Aug 23, 2022
|
|
||
| assert.Assert(t, strings.Contains(output, "simple Skipped - Image is already present locally")) | ||
| // image with :latest tag gets pulled regardless if pull_policy: missing or if_not_present | ||
| assert.Assert(t, strings.Contains(output, "latest Pulled")) |
There was a problem hiding this comment.
For ease of review, this was the change in the test, with the preceding comment and the accompanying change in the compose.yaml used for the test
nicksieger
approved these changes
Aug 23, 2022
| return false | ||
| } | ||
| _, ok = localImages[serviceImage] | ||
| return ok && tagged.Tag() != "latest" |
There was a problem hiding this comment.
Does ParseDockerRef normalize a missing tag to latest?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and pull policy is
missingorif_not_presentSigned-off-by: Laura Brehm laurabrehm@hey.com
What I did
Note: I also moved the
compose pullrelated tests fromcompose_test.gotopull_test.go.Related issue
(not mandatory) A picture of a cute animal, if possible in relation with what you did