Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error message showing exit code when using --exit-code-from #9783

Merged
merged 1 commit into from Aug 23, 2022
Merged

Remove error message showing exit code when using --exit-code-from #9783

merged 1 commit into from Aug 23, 2022

Conversation

mikesir87
Copy link
Member

What I did

Remove the unnecessary error message

Related issue
Fixes #9782

(not mandatory) A picture of a cute animal, if possible in relation with what you did
Panda chilling out

@mikesir87
Remove error message showing exit code when using --exit-code-from
d23c261 
Signed-off-by: Michael Irwin <mikesir87@gmail.com>

Resolves docker#9782
@laurazard
Copy link
Member

laurazard commented Aug 23, 2022 •
edited

When I use --exit-code-from I expect to explicitly see the exit code, regardless of whether it's 0 or not. I wonder if we can instead use a different log type (not logrus.Error) to still output that without confusing the user, instead of just omitting it.

Nevermind, I see it still explicitly outputs the exit code from the container 👍

@laurazard laurazard requested a review from a team August 23, 2022 14:55
laurazard
laurazard approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nicksieger
nicksieger approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@nicksieger nicksieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicksieger nicksieger merged commit 3aceaa1 into docker:v2 Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicksieger nicksieger nicksieger approved these changes

@laurazard laurazard laurazard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exit code printed as error when using --exit-code-from
3 participants
@mikesir87 @laurazard @nicksieger