Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add improvement output warning when pulling image #9829

Merged
merged 1 commit into from Sep 13, 2022

Conversation

RiskyFeryansyahP
Copy link
Contributor

What I did

Related to this issue, I added some improvements in the console output, where I added a warning status instead of an error when pulling an image produces an error but in the service has a build section.

Before Changes:
Screen Shot 2022-09-11 at 23 44 04

After Changes:
Screen Shot 2022-09-11 at 23 45 06

Related issue
fixes #9820

(not mandatory) A picture of a cute animal, if possible in relation with what you did
image

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for your contribution

Signed-off-by: Risky Feryansyah Pribadi <riskypribadi24@gmail.com>
@glours glours force-pushed the 9820-improvement-output-console branch from d94cafa to 9191079 Compare September 13, 2022 13:23
@RiskyFeryansyahP
Copy link
Contributor Author

Thanks @glours 🙏

Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks so much for the contribution!

@milas milas merged commit d05f5f5 into docker:v2 Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fallback build after failed image pull for service produces scary error message (but works)
3 participants