Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep the platform defined at service level during build if no build patforms provided #9847

Merged

Conversation

glours
Copy link
Contributor

@glours glours commented Sep 14, 2022

Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com

What I did
Fix an issue when the compose file defines a service.platform and don't provide services.build.platforms

Related issue
#9729 (comment)

(not mandatory) A picture of a cute animal, if possible in relation with what you did
image

@glours glours self-assigned this Sep 14, 2022
@glours glours force-pushed the fix-service-platform--without-build-platform branch from 85298ea to be2a37a Compare September 14, 2022 21:34
@glours glours mentioned this pull request Sep 14, 2022
@glours glours requested a review from a team September 14, 2022 21:45
…latforms provided

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours force-pushed the fix-service-platform--without-build-platform branch from be2a37a to 0e97526 Compare September 15, 2022 06:31
Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit b25a66b into docker:v2 Sep 15, 2022
@glours glours deleted the fix-service-platform--without-build-platform branch January 11, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants